Skip to content

support pagination in list applications method #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2023
Merged

support pagination in list applications method #21

merged 4 commits into from
May 24, 2023

Conversation

subinpc
Copy link
Member

@subinpc subinpc commented May 24, 2023

PR summary

Support pagination in list applications method

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

subinpc added 4 commits May 22, 2023 23:14
@subinpc
feat: add support for application list pagination
be68d67 
Application list results are now paginated.
Add properties and helper classes for accessing application list pages.

Signed-off-by: Subin Shekhar <[email protected]>
@subinpc
refactor: formatting changes
00da59e 
Signed-off-by: Subin Shekhar <[email protected]>
@subinpc
refactor: minor changes to examples
9ccabaf 
Signed-off-by: Subin Shekhar <[email protected]>
@subinpc
test: fix reference in integration test
8399f08 
Signed-off-by: Subin Shekhar <[email protected]>
@subinpc subinpc requested a review from ShyamalaGowri May 24, 2023 07:10
@subinpc
Copy link
Member Author

subinpc commented May 24, 2023

Integration tests -

======================================================================================== test session starts ========================================================================================
platform darwin -- Python 3.10.9, pytest-7.2.1, pluggy-1.0.0
rootdir: /Users/subin/Documents/gitworkspace/ibm-iae-python-sdk
plugins: rerunfailures-11.1, cov-2.12.1
collected 36 items                                                                                                                                                                                  

test/integration/test_ibm_analytics_engine_api_v2.py ssssssssssss                                                                                                                             [ 33%]
test/integration/test_ibm_analytics_engine_api_v3.py ........................                                                                                                                 [100%]

============================================================================= 24 passed, 12 skipped in 99.28s (0:01:39) =============================================================================

@ShyamalaGowri ShyamalaGowri merged commit f198d89 into master May 24, 2023
@Surya-Penumatcha
Copy link
Collaborator

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@subinpc subinpc deleted the subin-support-application-list-pagination branch May 24, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShyamalaGowri ShyamalaGowri ShyamalaGowri approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subinpc @Surya-Penumatcha @ShyamalaGowri