Update core User-Agent logic #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot supplied by an outside SDK
|
@padamstx this should be ready for a re-review |
padamstx
previously approved these changes
Mar 7, 2019
| @@ -153,6 +153,9 @@ | |||
| */ | |||
| String WWW_AUTHENTICATE = "WWW-Authenticate"; | |||
|
|
|||
| /** Header containing analytics info. */ | |||
| String X_IBMCLOUD_SDK_ANALYTICS = "X-IBMCloud-SDK-Analytics"; | |||
|
|
|||
There was a problem hiding this comment.
It doesn't seem right that a watson-specific header name is defined inside the core. At least I think this sdk analytics stuff is watson-specific. Anyway, it's not a showstopper or anything, but just seems a little odd is all.
There was a problem hiding this comment.
That's a good call actually. I'll move that out into the Watson SDK and make a point to get rid of other Watson-specific things in a later PR.
This reverts commit 190af0e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic regarding the
User-Agentheader.getUserAgent()now returns the core-specific information, which is the core package version and the various OS and Java versions. This can be called from SDKs that pull in the core as a dependency.This PR also ensures that, if the
User-Agentisn't set on a request, the core info is sent as theUser-Agent, so that something is always passed with the request.In the Java SDK, the method to set the
User-Agentwill look like this:This will result in something like the following: