-
Notifications
You must be signed in to change notification settings - Fork 21
Remove Watson references #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@padamstx three things:
|
Oh man, I wished we had talked about this before these name changes. The cloud object storage team has a current snapshot of the classes contained in the core in anticipation of moving to the new java core package. I'll need to check with them about any potential impact if we rename a bunch of classes. |
Ahh okay. Well we don't need to change things now if it's going to be a hassle. Although at some point I imagine it would make sense to make things more generic and it might be easier to make that transition now. |
@padamstx I just looked through the changes to verify that it won't cause breaking issues with users of SDKs relying on this core. The only thing that will change at that level is the removal of authentication using the old Other than that, it's just renaming, which should be resolved with a PR to the generator to capture the new base service class name and a re-gen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I never noticed that JNDI was mis-spelled JDNI. It's amazing what the human mind can filter out :)
The motivation for this PR was that I realized we really didn't need to have the Watson base test classes in the core, which could remove the testing dependency introduced in this earlier PR.
Along with that removal, it made sense to me to do a larger-scale refactoring to remove Watson-specific logic/references in anticipation of other teams taking advantage of this core library.