Replace reactive programming library #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and without added detail
BREAKING CHANGE: The rx() and rxWithDetails() methods have been removed. This type of functionality should be replaced with the new reactiveRequest() and reactiveRequestWithDetails() methods
padamstx
previously approved these changes
Mar 14, 2019
|
I think we want to default to detailed responses so maybe one of the reactive responses can be eliminated. |
|
Ah yeah I forgot about that actually. I'll go ahead and do that in this PR then for all versions. |
BREAKING CHANGE: The old executeWithDetails() and enqueueWithDetails() methods have been deleted. In addition, the basic versions of those methods now return the wrapped response that the old methods used to.
germanattanasio
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to watson-developer-cloud/java-sdk#1013
This PR replaces the current reactive programming library (https://mvnrepository.com/artifact/org.glassfish.jersey.bundles.repackaged/jersey-jsr166e) with RxJava.
This library was chosen because it is:
Tests have been added in this PR to ensure the two new execution method (
reactiveRequest()) work s properly, while documentation has been updated and is currently in review in the Watson SDK repo: watson-developer-cloud/java-sdk#1045Along with the above changes, both
executeWithDetails()andenqueueWithDetails()have been removed. The normal version of those methods now return the same wrapped HTTP response object, so that we always return the IBM Cloud API response + extra info.