Skip to content

chore: fix the build #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2020
Merged

chore: fix the build #16

merged 2 commits into from
Oct 31, 2020

Conversation

ajay-malhotra1
Copy link
Contributor

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #16 into master will increase coverage by 1.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   87.88%   89.33%   +1.45%     
==========================================
  Files          39       39              
  Lines       21958    21958              
==========================================
+ Hits        19297    19617     +320     
+ Misses       2661     2341     -320     
Impacted Files Coverage Δ
ibm_cloud_networking_services/zones_settings_v1.py 87.28% <0.00%> (+0.15%) ⬆️
ibm_cloud_networking_services/direct_link_v1.py 89.88% <0.00%> (+0.30%) ⬆️
...loud_networking_services/ssl_certificate_api_v1.py 87.63% <0.00%> (+0.55%) ⬆️
...m_cloud_networking_services/zone_rate_limits_v1.py 88.86% <0.00%> (+0.58%) ⬆️
...oud_networking_services/direct_link_provider_v2.py 88.66% <0.00%> (+0.71%) ⬆️
...oud_networking_services/transit_gateway_apis_v1.py 90.99% <0.00%> (+0.75%) ⬆️
...ud_networking_services/firewall_access_rules_v1.py 88.65% <0.00%> (+0.96%) ⬆️
ibm_cloud_networking_services/caching_api_v1.py 90.18% <0.00%> (+0.99%) ⬆️
...tworking_services/global_load_balancer_pools_v0.py 89.76% <0.00%> (+1.06%) ⬆️
ibm_cloud_networking_services/zones_v1.py 89.20% <0.00%> (+1.07%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebf913...438624d. Read the comment docs.

@ajay-malhotra1 ajay-malhotra1 merged commit f740260 into master Oct 31, 2020
@ajay-malhotra1 ajay-malhotra1 deleted the macsec branch October 31, 2020 22:43
@ajay-malhotra1
Copy link
Contributor Author

🎉 This PR is included in version 0.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant