Skip to content

Private DNS Services #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Private DNS Services #2

merged 2 commits into from
Jun 29, 2020

Conversation

KumarGanesanIBM
Copy link
Contributor

PR summary

Adding Private DNS services

Fixes:
n/a

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Private DNS services feature is not available

What is the new behavior?

Private DNS Services feature is available

Does this PR introduce a breaking change?

  • Yes
  • No

@KumarGanesanIBM KumarGanesanIBM self-assigned this Jun 29, 2020
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #2 into master will increase coverage by 0.36%.
The diff coverage is 94.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   87.51%   87.87%   +0.36%     
==========================================
  Files          31       34       +3     
  Lines        5551     5848     +297     
==========================================
+ Hits         4858     5139     +281     
- Misses        693      709      +16     
Impacted Files Coverage Δ
ibm_cloud_networking_services/__init__.py 100.00% <ø> (ø)
...ng_services/permitted_networks_for_dns_zones_v1.py 93.18% <93.18%> (ø)
ibm_cloud_networking_services/dns_zones_v1.py 94.79% <94.79%> (ø)
...m_cloud_networking_services/resource_records_v1.py 95.45% <95.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc4c73...59a1e0b. Read the comment docs.

@KumarGanesanIBM KumarGanesanIBM merged commit cd8fc89 into master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant