Skip to content

feat: add the authentication_key for BGP MD5 authentication in directlink service #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

ajay-malhotra1
Copy link
Contributor

PR summary

This PR addresses the following changes:

  1. Add the option to add the authentication_key while approving provider created gateways
  2. Add the authentication_key in the response while fetching gateways

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…link service

1. Add the option to add the authentication_key while approving provider created gateways
2. Add the authentication_key in the response while fetching gateways
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #26 (66ae69c) into master (1cac1bb) will increase coverage by 0.01%.
The diff coverage is 87.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   89.42%   89.43%   +0.01%     
==========================================
  Files          37       37              
  Lines       22276    22339      +63     
==========================================
+ Hits        19920    19980      +60     
- Misses       2356     2359       +3     
Impacted Files Coverage Δ
ibm_cloud_networking_services/direct_link_v1.py 89.94% <87.30%> (-0.09%) ⬇️
...oud_networking_services/direct_link_provider_v2.py 88.66% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cac1bb...66ae69c. Read the comment docs.

@ajay-malhotra1 ajay-malhotra1 merged commit c5b84e1 into master Jun 2, 2021
@ajay-malhotra1 ajay-malhotra1 deleted the md5 branch June 2, 2021 15:44
@ajay-malhotra1
Copy link
Contributor Author

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant