Skip to content

feat(firewall rules):Add Firewall Rules SDK #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Conversation

Santhi-Priya
Copy link
Contributor

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #44 (a2b6a31) into master (def999b) will increase coverage by 0.00%.
The diff coverage is 88.57%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #44    +/-   ##
========================================
  Coverage   88.43%   88.44%            
========================================
  Files          38       39     +1     
  Lines       25410    26233   +823     
========================================
+ Hits        22472    23201   +729     
- Misses       2938     3032    +94     
Impacted Files Coverage Δ
ibm_cloud_networking_services/firewall_rules_v1.py 88.55% <88.55%> (ø)
ibm_cloud_networking_services/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def999b...a2b6a31. Read the comment docs.

@Santhi-Priya Santhi-Priya merged commit 737d64f into master Oct 5, 2021
@ajay-malhotra1
Copy link
Contributor

🎉 This PR is included in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants