Skip to content

chore: Added integration tests for Classic, GRE, and DL connections. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

chore: Added integration tests for Classic, GRE, and DL connections. #49

merged 1 commit into from
Nov 2, 2021

Conversation

cacarrilloc
Copy link
Contributor

PR summary

The Integration Tests needed to be updated to cover other Transit connection types: GRE, DirectLink, and Classic.
Dependency: none

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

The process of deleting a classic connection with a GRE connection attached is failing during the test-resources cleanup.

What is the new behavior?

The bug mentioned above has been fixed. So other Transit connection types: GRE, DirectLink, and Classic, have been added.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N/A

@cacarrilloc cacarrilloc self-assigned this Oct 30, 2021
@cacarrilloc cacarrilloc added the enhancement New feature or request label Oct 31, 2021
The Integration Tests needed to be updated to cover other Transit connection types: GRE, DirectLink, and Classic.

Dependency: none
@cacarrilloc cacarrilloc merged commit c2c9f3c into IBM:master Nov 2, 2021
@ajay-malhotra1
Copy link
Contributor

🎉 This PR is included in version 0.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants