Skip to content

feat(location opt): added cr location as opt #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2021

Conversation

shailajamahara
Copy link
Contributor

PR summary

Added custom resolver location as optional

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behaviour?

Custom resolver location is not optional and added during create

What is the new behaviour?

Custom resolver location is optional and can be added later

Does this PR introduce a breaking change?

  • Yes
  • No

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #50 (818d6e8) into master (c2c9f3c) will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   88.36%   88.76%   +0.40%     
==========================================
  Files          39       39              
  Lines       26233    26255      +22     
==========================================
+ Hits        23180    23305     +125     
+ Misses       3053     2950     -103     
Impacted Files Coverage Δ
ibm_cloud_networking_services/dns_svcs_v1.py 92.37% <100.00%> (+3.17%) ⬆️
ibm_cloud_networking_services/zones_settings_v1.py 88.02% <0.00%> (+0.14%) ⬆️
ibm_cloud_networking_services/filters_v1.py 89.51% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c9f3c...818d6e8. Read the comment docs.

Copy link
Member

@MalarvizhiK MalarvizhiK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shailajamahara shailajamahara merged commit 1f72932 into master Nov 16, 2021
@shailajamahara shailajamahara deleted the location_asoptional branch November 16, 2021 11:17
@ajay-malhotra1
Copy link
Contributor

🎉 This PR is included in version 0.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants