Skip to content

feat(Resource Manager): add service to project #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 7, 2020
Merged

feat(Resource Manager): add service to project #15

merged 7 commits into from
May 7, 2020

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented May 4, 2020 •
edited
Loading

PR summary

This PR adds the Resource Manager V2 service to the project.

Fixes: n/a

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx
Copy link
Member Author

padamstx commented May 4, 2020

@inamdarapurva Here's the PR with RM service :)

@padamstx padamstx self-assigned this May 4, 2020
@codecov
Copy link

codecov bot commented May 4, 2020 •
edited
Loading

Codecov Report

Merging #15 into master will increase coverage by 0.06%.
The diff coverage is 94.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   94.15%   94.22%   +0.06%     
==========================================
  Files           7        8       +1     
  Lines        4158     4570     +412     
==========================================
+ Hits         3915     4306     +391     
- Misses        243      264      +21
Impacted Files Coverage Δ
ibm_platform_services/resource_manager_v2.py 94.89% <94.89%> (ø)
ibm_platform_services/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1cac55...21d82f0. Read the comment docs.

@padamstx padamstx requested review from inamdarapurva and mahakAg May 7, 2020 11:55
inamdarapurva
inamdarapurva approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@inamdarapurva inamdarapurva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@padamstx padamstx merged commit 2789fdb into master May 7, 2020
ibm-devx-automation pushed a commit that referenced this pull request May 7, 2020
@semantic-release-bot
chore(release): 0.4.0 release notes
1aa1108 
# [0.4.0](v0.3.3...v0.4.0) (2020-05-07)

### Features

* **Resource Manager:** add service to project ([#15](#15)) ([2789fdb](2789fdb))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@padamstx padamstx deleted the add-rm branch May 28, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inamdarapurva inamdarapurva inamdarapurva approved these changes

@mahakAg mahakAg Awaiting requested review from mahakAg

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@padamstx @ibm-devx-automation @inamdarapurva