Skip to content

feat(Enterprise Billing Units): add start and limit parameters to billing unit APIs #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 29, 2023

Conversation

Jdatechong
Copy link
Contributor

PR summary

Adds start and limit parameters to support pagination for certain Enterprise Billing Units APIs

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Results can now be optionally paginated using the start and limit parameters.

Does this PR introduce a breaking change?

  • Yes
  • No

Test results

$python3 -m pytest test/unit/test_enterprise_billing_units_v1.py                                           
============================================================== test session starts ==============================================================
platform darwin -- Python 3.10.8, pytest-7.2.0, pluggy-1.0.0
plugins: cov-2.12.1
collected 36 items                                                                                                                              

test/unit/test_enterprise_billing_units_v1.py ....................................                                                        [100%]

============================================================== 36 passed in 0.36s ===============================================================

@padamstx padamstx self-assigned this Jan 24, 2023
@padamstx padamstx self-requested a review January 24, 2023 21:54
@padamstx
Copy link
Member

Also need to update the examples and integration tests to reflect the use of the Pagers. Please see the recent changes to the Enterprise Usage Reports service for an example of similar changes in this commit

@padamstx
Copy link
Member

I noticed that the travis build failed in the lint step. Be sure to run make lint-fix in your local sandbox to fix any linter issues that can be fixed automatically. If any other lint problems exist, then those would need to be handled manually.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx
Copy link
Member

padamstx commented Feb 2, 2023

@Jdatechong this PR's build had lint errors. To fix these, in your local sandbox run make lint-fix, then commit the changes. Be sure to manually fix any problems that weren't fixed automatically.

Jdatechong and others added 7 commits February 7, 2023 11:39
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
@Jdatechong
Copy link
Contributor Author

Integration test results:

============================================================= test session starts ==============================================================
platform darwin -- Python 3.10.10, pytest-7.2.0, pluggy-1.0.0
rootdir: /Users/jonathan/Workfiles/BSS/sdkupdate/jdc/platform-services-python-sdk
plugins: cov-2.12.1
collected 8 items                                                                                                                              

test/integration/test_enterprise_billing_units_v1.py ........                                                                            [100%]

============================================================== 8 passed in 11.02s ==============================================================

Examples results:

============================================================= test session starts ==============================================================
platform darwin -- Python 3.10.10, pytest-7.2.0, pluggy-1.0.0
rootdir: /Users/jonathan/Workfiles/BSS/sdkupdate/jdc/platform-services-python-sdk
plugins: cov-2.12.1
collected 4 items                                                                                                                              

examples/test_enterprise_billing_units_v1_examples.py ....                                                                               [100%]

============================================================== 4 passed in 10.08s ==============================================================

@padamstx padamstx merged commit b15781d into IBM:main Mar 29, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Mar 29, 2023
# [0.32.0](v0.31.2...v0.32.0) (2023-03-29)

### Features

* **Enterprise Billing Units:** add start and limit parameters to billing unit list APIs ([#189](#189)) ([b15781d](b15781d))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants