-
Notifications
You must be signed in to change notification settings - Fork 42
feat(Enterprise Billing Units): add start and limit parameters to billing unit APIs #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ling unit APIs Signed-off-by: Jonathan Date-chong <[email protected]>
Also need to update the examples and integration tests to reflect the use of the Pagers. Please see the recent changes to the Enterprise Usage Reports service for an example of similar changes in this commit |
I noticed that the travis build failed in the lint step. Be sure to run |
Signed-off-by: Jonathan Date-chong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Jdatechong this PR's build had lint errors. To fix these, in your local sandbox run |
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
Integration test results:
Examples results:
|
# [0.32.0](v0.31.2...v0.32.0) (2023-03-29) ### Features * **Enterprise Billing Units:** add start and limit parameters to billing unit list APIs ([#189](#189)) ([b15781d](b15781d))
🎉 This PR is included in version 0.32.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Adds start and limit parameters to support pagination for certain Enterprise Billing Units APIs
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Results can now be optionally paginated using the start and limit parameters.
Does this PR introduce a breaking change?
Test results