Skip to content

feat (User Management): add query params search and include_settings to list_users operation #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

PureMathematics
Copy link
Contributor

PR summary

Update Include_settings and substring search functionality (User Management)

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

the current issue for updating SDK https://github.ibm.com/IAM/uum/issues/5882
the previous issue for the user management code change https://github.ibm.com/IAM/uum/issues/4948

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


David-Lim0305 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from c25bcbd to 814f55e Compare April 25, 2023 20:51
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 814f55e to f848abe Compare April 25, 2023 21:15
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from f848abe to 9a73594 Compare April 25, 2023 21:45
@padamstx padamstx self-requested a review April 25, 2023 21:45
@padamstx padamstx self-assigned this Apr 25, 2023
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 9a73594 to 3813610 Compare April 25, 2023 22:33
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good except for the same issues as the other PRs:

  1. use git commit -s option
  2. one code fragment per operation in the examples

Also, please run "make lint-fix" in your sandbox to reformat the source files and then commit those results (see update_service.md).

PureMathematics pushed a commit that referenced this pull request Apr 27, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 3813610 to cbb9d2c Compare April 27, 2023 21:46
PureMathematics pushed a commit that referenced this pull request Apr 27, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from cbb9d2c to 8281f67 Compare April 27, 2023 21:47
@padamstx padamstx changed the title feat (user management) update user management sdk with list user api update feat (User Management): add query params search and include_settings to list_users operation Apr 28, 2023
PureMathematics pushed a commit that referenced this pull request Apr 28, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 8281f67 to f8f289a Compare April 28, 2023 14:20
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from f8f289a to f076659 Compare April 28, 2023 15:32
@PureMathematics
Copy link
Contributor Author

integration test
python-integration

@PureMathematics
Copy link
Contributor Author

examples test
python-example

Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 30263a0 into main Apr 28, 2023
@padamstx padamstx deleted the update-uum-listusers-api-sdk branch April 28, 2023 22:56
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants