-
Notifications
You must be signed in to change notification settings - Fork 42
feat (User Management): add query params search and include_settings to list_users operation #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
David-Lim0305 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
… for GET list users API (#198) Signed-off-by: David Lim <[email protected]>
c25bcbd
to
814f55e
Compare
… for GET list users API (#198) Signed-off-by: David Lim <[email protected]>
814f55e
to
f848abe
Compare
… for GET list users API (#198) Signed-off-by: David Lim <[email protected]>
f848abe
to
9a73594
Compare
… for GET list users API (#198) Signed-off-by: David Lim <[email protected]>
9a73594
to
3813610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good except for the same issues as the other PRs:
- use git commit -s option
- one code fragment per operation in the examples
Also, please run "make lint-fix" in your sandbox to reformat the source files and then commit those results (see update_service.md).
… for GET list users API (#198) Signed-off-by: David Lim <[email protected]>
3813610
to
cbb9d2c
Compare
… for GET list users API (#198) Signed-off-by: David Lim <[email protected]>
cbb9d2c
to
8281f67
Compare
… for GET list users API (#198) Signed-off-by: David Lim <[email protected]>
8281f67
to
f8f289a
Compare
… for GET list users API (#198) Signed-off-by: David Lim <[email protected]>
f8f289a
to
f076659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 0.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Update Include_settings and substring search functionality (User Management)
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information
the current issue for updating SDK https://github.ibm.com/IAM/uum/issues/5882
the previous issue for the user management code change https://github.ibm.com/IAM/uum/issues/4948