Skip to content

feat(IAM Identity): add trusted profile identities api #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

feat(IAM Identity): add trusted profile identities api #206

merged 1 commit into from
Jun 9, 2023

Conversation

Somchavan
Copy link
Contributor

PR summary

Added feature support for Trusted Profile identities work, add, get, delete identities associated with the profile.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

SDK adopters will be able to call Trusted profile identities APIs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

API defintion:
Staging

Test information:

Integration Tests:

========================================================== test session starts ===========================================================
platform win32 -- Python 3.10.9, pytest-7.3.1, pluggy-1.0.0
rootdir: C:\Users\SomanathChavan\SDK\platform-services-python-sdk
collected 41 items

examples\test_iam_identity_v1_examples.py .........................................                                                 [100%]

========================================================== 41 passed in 20.75s =========================================================== 
(platform-services-python-sdk) PS C:\Users\SomanathChavan\SDK\platform-services-python-sdk> python -m pytest test/integration/test_iam_identity_v1.py  
========================================================== test session starts ===========================================================
platform win32 -- Python 3.10.9, pytest-7.3.1, pluggy-1.0.0
rootdir: C:\Users\SomanathChavan\SDK\platform-services-python-sdk
collected 61 items

test\integration\test_iam_identity_v1.py .............................................................                              [100%]

========================================================== 61 passed in 34.35s ===========================================================

@Somchavan Somchavan requested a review from padamstx June 6, 2023 14:03
@Somchavan Somchavan force-pushed the iam-identity-profile-identities branch from 043da65 to 3f90c90 Compare June 6, 2023 14:15
@padamstx padamstx self-assigned this Jun 7, 2023
@Somchavan Somchavan force-pushed the iam-identity-profile-identities branch from 3f90c90 to edb0108 Compare June 7, 2023 15:38
padamstx
padamstx approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 3b0f952 into main Jun 9, 2023
@padamstx padamstx deleted the iam-identity-profile-identities branch June 9, 2023 13:04
ibm-devx-sdk pushed a commit that referenced this pull request Jun 9, 2023
@semantic-release-bot
chore(release): 0.37.0 release notes
1354438 
# [0.37.0](v0.36.0...v0.37.0) (2023-06-09)

### Features

* **IAM Identity:** add trusted profile identities API ([#206](#206)) ([3b0f952](3b0f952))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.37.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Somchavan @ibm-devx-sdk @padamstx