Skip to content

feat(IAM Identity): Add support for IAM enterprise #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

michaelbeck
Copy link
Contributor

PR summary

Added support for IAM enterprise feature. Enterprise admins can create templates for account settings and trusted profiles and assign them to accounts and account groups in the enterprise.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

SDK adopters will be able to work with IAM enterprise feature.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

API definition: Staging

Test information:

Integration Tests:

==================================================== test session starts ====================================================
platform win32 -- Python 3.10.11, pytest-7.4.0, pluggy-1.2.0
rootdir: D:\BlueMix\repos\platform-services-python-sdk
collected 87 items

test\integration\test_iam_identity_v1.py ............................................................................. [ 88%]
..........                                                                                                             [100%]

============================================== 87 passed in 701.43s (0:11:41) ===============================================

Examples:

==================================================== test session starts ====================================================
platform win32 -- Python 3.10.11, pytest-7.4.0, pluggy-1.2.0
rootdir: D:\BlueMix\repos\platform-services-python-sdk
collected 68 items

examples\test_iam_identity_v1_examples.py ....................................................................         [100%]

============================================== 68 passed in 657.28s (0:10:57) ===============================================

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@padamstx padamstx self-assigned this Aug 14, 2023
@padamstx padamstx self-requested a review August 14, 2023 17:54
@padamstx
Copy link
Member

@michaelbeck looks like the travis build failed the lint check step.
Be sure to follow the instructions in https://github.com/IBM/platform-services-python-sdk/blob/main/update_service.md when updating a service.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good... just need to fix the lint errors.

@michaelbeck
Copy link
Contributor Author

michaelbeck commented Aug 15, 2023

@michaelbeck looks like the travis build failed the lint check step. Be sure to follow the instructions in https://github.com/IBM/platform-services-python-sdk/blob/main/update_service.md when updating a service.

I tried to follow the steps but again these were referencing an .sh file which would not run under Windows. Please make sure your instructions are valid/working for all developers.

Also when I try to run the command from the .sh file, it will respond with No module named pylint. After running pip3 install pylint the linter woked. So please include this with your installation instructions.

@pyrooka
Copy link
Member

pyrooka commented Aug 15, 2023

Hi @michaelbeck!

Also when I try to run the command from the .sh file, it will respond with No module named pylint. After running pip3 install pylint the linter woked. So please include this with your installation instructions.

If you look at the documentation, the last command in the "Initial project setup" is make all which installs all the required dependencies, so if you have run that you shouldn't see any dependency issues.

I think the main problem here is that you are using Windows which is really different from Linux/macOS - what most developers use. Do you have WSL installed by any chance? You might want to give it a try, because I think the compatibility and the whole experience would be much better.

@michaelbeck
Copy link
Contributor Author

Hi @michaelbeck!

Also when I try to run the command from the .sh file, it will respond with No module named pylint. After running pip3 install pylint the linter woked. So please include this with your installation instructions.

If you look at the documentation, the last command in the "Initial project setup" is make all which installs all the required dependencies, so if you have run that you shouldn't see any dependency issues.

I think the main problem here is that you are using Windows which is really different from Linux/macOS - what most developers use. Do you have WSL installed by any chance? You might want to give it a try, because I think the compatibility and the whole experience would be much better.

Exactly, make all does not work on Windows. And no, I don't have WSL running. You expect teams to support SDK and Terraform generation, that means teams can expect you to support Windows, which is a viable OS in IBM. Fine for me to setup WSL but then please give advice to do so and clear guidance how to.

@pyrooka
Copy link
Member

pyrooka commented Aug 15, 2023

Well, when I see an instruction that says "let's use X" and X doesn't work in/support my environment I'd assume that I have to use somethings else that X supports. I think using WSL/Docker/VM is a totally valid scenario. Maybe we can mention this in the docs, we'll discuss.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint errors are fixed and a small change to .travis.yml allowed the Travis build to run clean (there appears to be a problem with the Travis jammy build image which prevents builds from running sudo api-get update to update the OS during the build.

@padamstx padamstx merged commit 6b92c4a into IBM:main Aug 15, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Aug 15, 2023
# [0.39.0](v0.38.0...v0.39.0) (2023-08-15)

### Features

* **IAM Identity:** add support for IAM enterprise ([#213](#213)) ([6b92c4a](6b92c4a))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.39.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@michaelbeck michaelbeck deleted the issue-6829 branch August 15, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants