-
Notifications
You must be signed in to change notification settings - Fork 42
feat(IAM Identity): Add support for IAM enterprise #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@michaelbeck looks like the travis build failed the lint check step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good... just need to fix the lint errors.
I tried to follow the steps but again these were referencing an .sh file which would not run under Windows. Please make sure your instructions are valid/working for all developers. Also when I try to run the command from the .sh file, it will respond with |
Hi @michaelbeck!
If you look at the documentation, the last command in the "Initial project setup" is I think the main problem here is that you are using Windows which is really different from Linux/macOS - what most developers use. Do you have WSL installed by any chance? You might want to give it a try, because I think the compatibility and the whole experience would be much better. |
Exactly, |
9422c28
to
776e90a
Compare
Well, when I see an instruction that says "let's use X" and X doesn't work in/support my environment I'd assume that I have to use somethings else that X supports. I think using WSL/Docker/VM is a totally valid scenario. Maybe we can mention this in the docs, we'll discuss. |
Signed-off-by: Michael Beck <[email protected]>
776e90a
to
c536044
Compare
Signed-off-by: Phil Adams <[email protected]>
Signed-off-by: Phil Adams <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint errors are fixed and a small change to .travis.yml allowed the Travis build to run clean (there appears to be a problem with the Travis jammy build image which prevents builds from running sudo api-get update
to update the OS during the build.
# [0.39.0](v0.38.0...v0.39.0) (2023-08-15) ### Features * **IAM Identity:** add support for IAM enterprise ([#213](#213)) ([6b92c4a](6b92c4a))
🎉 This PR is included in version 0.39.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Added support for IAM enterprise feature. Enterprise admins can create templates for account settings and trusted profiles and assign them to accounts and account groups in the enterprise.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
SDK adopters will be able to work with IAM enterprise feature.
Does this PR introduce a breaking change?
Other information
API definition: Staging
Test information:
Integration Tests:
Examples: