Skip to content

feat(Usage Reports): add billing snapshot config service to usage reports #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

manukm-ibm
Copy link
Member

@manukm-ibm manukm-ibm commented Aug 21, 2023

PR summary

Introducing new CRUD APIs to configure billing reports snapshot.
TRI: https://github.ibm.com/BSS/architecture/blob/master/design-docs/services/billing/apptio-integration.md
Issue: https://github.ibm.com/BSS/metering-deliverables/issues/1990

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2023

CLA assistant check
All committers have signed the CLA.

@padamstx padamstx self-assigned this Aug 21, 2023
@padamstx padamstx self-requested a review August 21, 2023 18:42
@padamstx padamstx changed the title feat(Usage Reports): add billing snapshot config service to usage rep… feat(Usage Reports): add billing snapshot config service to usage reports Aug 21, 2023
@padamstx
Copy link
Member

@manukm-ibm Travis build had lint errors: https://app.travis-ci.com/github/IBM/platform-services-python-sdk/jobs/608331262

To fix, see the instructions in update_service.md, then commit changes.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need updates to int tests and examples

@@ -1,5 +1,5 @@
# -*- coding: utf-8 -*-
# (C) Copyright IBM Corp. 2020.
# (C) Copyright IBM Corp. 2023.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear that, by re-generating this entire file, you've lost all the manual changes that were needed for the tests to run cleanly. Were you able to run all the int tests after re-generating?

I would recommend reverting the changes to this file to get back to the original version, then generate the int tests off to the side, then copy/paste the test code blocks related to the new operations into your checked-in version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the working examples code will need to be updated to provide working examples of the 6 new operations.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manukm-ibm
Copy link
Member Author

Integration test results of new changes
Screenshot 2023-09-14 at 12 52 54 PM
Examples results of new changes
Screenshot 2023-09-14 at 1 28 51 PM

@padamstx padamstx merged commit 7a3a43b into IBM:main Sep 14, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Sep 14, 2023
# [0.42.0](v0.41.0...v0.42.0) (2023-09-14)

### Features

* **Usage Reports:** add billing snapshot config service to usage reports ([#214](#214)) ([7a3a43b](7a3a43b))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants