-
Notifications
You must be signed in to change notification settings - Fork 42
feat(Usage Reports): add billing snapshot config service to usage reports #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@manukm-ibm Travis build had lint errors: https://app.travis-ci.com/github/IBM/platform-services-python-sdk/jobs/608331262 To fix, see the instructions in update_service.md, then commit changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need updates to int tests and examples
@@ -1,5 +1,5 @@ | |||
# -*- coding: utf-8 -*- | |||
# (C) Copyright IBM Corp. 2020. | |||
# (C) Copyright IBM Corp. 2023. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fear that, by re-generating this entire file, you've lost all the manual changes that were needed for the tests to run cleanly. Were you able to run all the int tests after re-generating?
I would recommend reverting the changes to this file to get back to the original version, then generate the int tests off to the side, then copy/paste the test code blocks related to the new operations into your checked-in version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the working examples code will need to be updated to provide working examples of the 6 new operations.
…orts Signed-off-by: manu.k.m <[email protected]>
3b2dd2a
to
0f246c5
Compare
…napshot config service Signed-off-by: manu.k.m <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# [0.42.0](v0.41.0...v0.42.0) (2023-09-14) ### Features * **Usage Reports:** add billing snapshot config service to usage reports ([#214](#214)) ([7a3a43b](7a3a43b))
🎉 This PR is included in version 0.42.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Introducing new CRUD APIs to configure billing reports snapshot.
TRI: https://github.ibm.com/BSS/architecture/blob/master/design-docs/services/billing/apptio-integration.md
Issue: https://github.ibm.com/BSS/metering-deliverables/issues/1990
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information