feat(Context-Based Restrictions): add service group support to Operations #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dylan <[email protected]>
Signed-off-by: Dylan <[email protected]>
|
|
Signed-off-by: Dylan <[email protected]>
Signed-off-by: Dylan <[email protected]>
soohoowoohoo
suggested changes
Sep 14, 2023
Comment on lines
47
to
53
| account_id = None | ||
| service_name = None | ||
| vpc_crn = None | ||
| zone_id = None | ||
| zone_rev = None | ||
| rule_id = None | ||
| rule_rev = None |
There was a problem hiding this comment.
I don't think we want to remove these values. You'll need them for the example regeneration. This applies to basically every change in this file.
Signed-off-by: Dylan <[email protected]>
|
@JonahFarc Dylan, looks like there were lint errors in the Travis build. Please run |
padamstx
requested changes
Sep 15, 2023
Signed-off-by: Dylan <[email protected]>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Sep 15, 2023
# [0.43.0](v0.42.0...v0.43.0) (2023-09-15) ### Features * **Context-Based Restrictions:** add service group support to operations ([#219](#219)) ([8b666db](8b666db))
|
🎉 This PR is included in version 0.43.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Adds service group support to operations
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
service_name parameter can now be replaced with the service group parameter.
Does this PR introduce a breaking change?