Skip to content

feat(IAM Policy Management): re-gen service after fix the template metadata as part of policies #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat(IAM Policy Management): re-gen service after fix the template metadata as part of policies #222

merged 2 commits into from
Sep 25, 2023

Conversation

Rajesh-Pirati
Copy link
Contributor

PR summary

Issue: https://github.ibm.com/IAM/AM-issues/issues/1803

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

pytest test/integration/test_iam_policy_management_v1.py 
==================================================================================================================== test session starts =====================================================================================================================
platform darwin -- Python 3.11.5, pytest-7.4.2, pluggy-1.3.0
rootdir: /Users/rajesh/iam-project/platform-sdk/platform-services-python-sdk
plugins: cov-2.12.1
collected 27 items                                                                                                                                                                                                                                           

test/integration/test_iam_policy_management_v1.py ...........................                                                                                                                                                                          [100%]

==================================================================================================================== 27 passed in 16.97s =====================================================================================================================

pytest examples/test_iam_policy_management_v1_examples.py
==================================================================================================================== test session starts =====================================================================================================================
platform darwin -- Python 3.11.5, pytest-7.4.2, pluggy-1.3.0
rootdir: /Users/rajesh/iam-project/platform-sdk/platform-services-python-sdk
plugins: cov-2.12.1
collected 28 items                                                                                                                                                                                                                                           

examples/test_iam_policy_management_v1_examples.py ............................                                                                                                                                                                        [100%]

==================================================================================================================== 28 passed in 24.52s =====================================================================================================================

@Rajesh-Pirati Rajesh-Pirati marked this pull request as ready for review September 25, 2023 14:09
@padamstx padamstx self-assigned this Sep 25, 2023
padamstx
padamstx approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 1aa04ce into main Sep 25, 2023
@padamstx padamstx deleted the policy-assignment-metadata branch September 25, 2023 16:52
ibm-devx-sdk pushed a commit that referenced this pull request Sep 25, 2023
@semantic-release-bot
chore(release): 0.44.0 release notes
2edb401 
# [0.44.0](v0.43.1...v0.44.0) (2023-09-25)

### Features

* **IAM Policy Management:** re-gen service after fix the template metadata as part of policies ([#222](#222)) ([1aa04ce](1aa04ce))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rajesh-Pirati @ibm-devx-sdk @padamstx