Skip to content

fix(Resource Manager): re-gen service after API definition updates #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2020

Conversation

padamstx
Copy link
Member

PR summary

This PR contains a re-generation of the Resource Manager service after
recent changes to the API definition.

Fixes: n/a

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx requested a review from inamdarapurva May 11, 2020 21:55
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 96.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files           8        8           
  Lines        4570     4570           
=======================================
  Hits         4306     4306           
  Misses        264      264           
Impacted Files Coverage Δ
ibm_platform_services/resource_manager_v2.py 94.89% <96.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa1108...0887798. Read the comment docs.

@inamdarapurva
Copy link
Contributor

Looks good

@padamstx padamstx merged commit 2bbb8e9 into master May 11, 2020
ibm-devx-automation pushed a commit that referenced this pull request May 12, 2020
## [0.4.1](v0.4.0...v0.4.1) (2020-05-12)

### Bug Fixes

* **Resource Manager:** re-gen service after API definition updates ([#23](#23)) ([2bbb8e9](2bbb8e9))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ycs334 pushed a commit to ycs334/platform-services-python-sdk that referenced this pull request May 18, 2020
ycs334 pushed a commit to ycs334/platform-services-python-sdk that referenced this pull request May 18, 2020
## [0.4.1](IBM/platform-services-python-sdk@v0.4.0...v0.4.1) (2020-05-12)

### Bug Fixes

* **Resource Manager:** re-gen service after API definition updates ([IBM#23](IBM#23)) ([2bbb8e9](IBM@2bbb8e9))
@padamstx padamstx deleted the regen-rm branch May 28, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants