Skip to content

feat(IAM Identity): adding Identity Preference API #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

pooraniss-ibm
Copy link
Member

@pooraniss-ibm pooraniss-ibm commented Feb 24, 2025

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx
Copy link
Member

padamstx commented Feb 24, 2025

Please amend your commit with the -s command-line option to sign off on the commit, then force-push. That will fix the failing "DCO" check above.

Edit: also, there's a linter error present. In your local sandbox, please run make lint-fix to fix the errors, then make all to build/test/lint the project again to make sure everything is green, then push your changes.

Also, assuming that is all clean please post evidence that the integration tests and examples code runs clean.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, but just need to address the items I mentioned in my other comments.

@padamstx padamstx self-assigned this Feb 24, 2025
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, inadvertently clicked Approve :)

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-preferences branch 3 times, most recently from 8293a47 to 547d454 Compare March 5, 2025 22:38
@padamstx padamstx force-pushed the iam-identity-preferences branch from 547d454 to bb9c8bd Compare March 7, 2025 16:06
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed changes to fix the linter errors.

@padamstx padamstx merged commit 93862bd into main Mar 7, 2025
16 checks passed
@padamstx padamstx deleted the iam-identity-preferences branch March 7, 2025 16:21
ibm-devx-sdk pushed a commit that referenced this pull request Mar 7, 2025
# [0.61.0](v0.60.0...v0.61.0) (2025-03-07)

### Features

* **IAM Identity:** add Identity Preference API ([#284](#284)) ([93862bd](93862bd))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.61.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants