Skip to content

fix(Global Catalog): fix price field capitalization #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

benbuchanan
Copy link
Contributor

PR summary

Regen after api definition fixes like Price to price, include url field for object update, and support deployment_region query param

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Fixes object update and price field syntax

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Integration tests

python3 -m pytest test/integration/test_global_catalog_v1.py
27 passed, 15 warnings in 16.83s

Example tests

python3 -m pytest examples/test_global_catalog_v1_examples.py
15 passed, 1 warning in 3.89s

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2025

CLA assistant check
All committers have signed the CLA.

@benbuchanan benbuchanan requested a review from padamstx March 13, 2025 15:07
@padamstx padamstx self-assigned this Mar 13, 2025
@padamstx
Copy link
Member

@benbuchanan your python PR build has some lint errors. Please run make lint-fix in your sandbox, then commit the changes. You can verify by running make lint.

@padamstx padamstx changed the title fix(GlobalCatalog): regen after api definition fixes fix(Global Catalog): fix price field capitalization Mar 13, 2025
Signed-off-by: Ben Buchanan <[email protected]>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit cb333fd into IBM:main Mar 13, 2025
9 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Mar 13, 2025
## [0.61.1](v0.61.0...v0.61.1) (2025-03-13)

### Bug Fixes

* **Global Catalog:** fix price field capitalization ([#286](#286)) ([cb333fd](cb333fd))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.61.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants