Skip to content

feat(Global Catalog): support non ibm only visibility #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

benbuchanan
Copy link
Contributor

PR summary

Allow updates to GC object visibility.restrictions field. Updated docs for the "non ibm only" restriction type. Other doc updates and metadata fields were added.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Used to not be able to update the restrictions field on a visibility update, but have always been able to in the API, so now you can in the SDK.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Integration tests:

python3 -m pytest test/integration/test_global_catalog_v1.py
===================================================================== test session starts =====================================================================
platform darwin -- Python 3.13.2, pytest-7.4.4, pluggy-1.6.0
rootdir: /Users/benbuchanan/Developer/platform-services-python-sdk
plugins: cov-4.1.0
collected 27 items                                                                                                                                            

test/integration/test_global_catalog_v1.py ...........................                                                                                  [100%]

====================================================================== warnings summary =======================================================================
test/integration/test_global_catalog_v1.py: 14 warnings
  /Users/benbuchanan/Developer/platform-services-python-sdk/venv/lib/python3.13/site-packages/ibm_cloud_sdk_core/api_exception.py:56: DeprecationWarning: Using the `code` attribute on the `ApiException` is deprecated and will be removed in the future. Use `status_code` instead.
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================================================== 27 passed, 14 warnings in 20.94s ===============================================================

Example tests:

python3 -m pytest examples/test_global_catalog_v1_examples.py
===================================================================== test session starts =====================================================================
platform darwin -- Python 3.13.2, pytest-7.4.4, pluggy-1.6.0
rootdir: /Users/benbuchanan/Developer/platform-services-python-sdk
plugins: cov-4.1.0
collected 15 items                                                                                                                                            

examples/test_global_catalog_v1_examples.py ...............                                                                                             [100%]

===================================================================== 15 passed in 3.94s ======================================================================

Signed-off-by: Ben Buchanan <[email protected]>
@benbuchanan benbuchanan requested a review from padamstx May 20, 2025 14:03
@padamstx padamstx self-assigned this May 20, 2025
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit eeb6fb5 into IBM:main May 20, 2025
9 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request May 20, 2025
# [0.66.0](v0.65.0...v0.66.0) (2025-05-20)

### Features

* **Global Catalog:** support non ibm only visibility ([#291](#291)) ([eeb6fb5](eeb6fb5))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.66.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants