Skip to content

feat(Resource Controller): add service to project #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 16, 2020
Merged

feat(Resource Controller): add service to project #30

merged 17 commits into from
Jul 16, 2020

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Jun 4, 2020

PR summary

This PR adds the Resource Controller service to the project.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #30 into master will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   94.48%   94.34%   -0.15%     
==========================================
  Files          13       14       +1     
  Lines       12315    13570    +1255     
==========================================
+ Hits        11636    12802    +1166     
- Misses        679      768      +89     
Impacted Files Coverage Δ
ibm_platform_services/resource_controller_v2.py 95.21% <ø> (ø)
ibm_platform_services/__init__.py 100.00% <100.00%> (ø)
ibm_platform_services/iam_policy_management_v1.py 93.76% <0.00%> (-1.28%) ⬇️
ibm_platform_services/open_service_broker_v1.py 91.34% <0.00%> (-0.78%) ⬇️
ibm_platform_services/case_management_v1.py 91.34% <0.00%> (-0.36%) ⬇️
ibm_platform_services/iam_access_groups_v2.py 94.41% <0.00%> (-0.34%) ⬇️
ibm_platform_services/global_catalog_v1.py 94.58% <0.00%> (-0.17%) ⬇️
ibm_platform_services/catalog_management_v1.py 95.36% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b7e37...fc8a72d. Read the comment docs.

@padamstx padamstx merged commit 6f03ac0 into master Jul 16, 2020
@padamstx padamstx deleted the add-rc branch July 16, 2020 18:53
ibm-devx-automation pushed a commit that referenced this pull request Jul 17, 2020
# [0.10.0](v0.9.3...v0.10.0) (2020-07-17)

### Features

* **Resource Controller:** add service to project ([#30](#30)) ([6f03ac0](6f03ac0))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants