Skip to content

fix(User Management): re-gen user-mgmt service #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Conversation

padamstx
Copy link
Member

PR summary

This PR contains a re-gen of the User Management service, along with the addition of an integration test.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Sep 16, 2020
@padamstx
Copy link
Member Author

@mahakAg Please pull this feature branch, complete the integration test, then push your commit back to the feature branch after it runs clean.

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #47 into master will increase coverage by 0.00%.
The diff coverage is 97.05%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          16       16           
  Lines       15582    15609   +27     
=======================================
+ Hits        14652    14678   +26     
- Misses        930      931    +1     
Impacted Files Coverage Δ
ibm_platform_services/user_management_v1.py 93.99% <97.05%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c550ef9...ea775a9. Read the comment docs.

@padamstx padamstx merged commit c7953a8 into master Sep 16, 2020
@padamstx padamstx deleted the regen-user-mgmt branch September 16, 2020 21:37
ibm-devx-automation pushed a commit that referenced this pull request Sep 16, 2020
## [0.12.1](v0.12.0...v0.12.1) (2020-09-16)

### Bug Fixes

* **User Management:** re-gen user-mgmt service ([#47](#47)) ([c7953a8](c7953a8))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants