Skip to content

feat(Global Catalog): add service and unit test code to project #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 24, 2020
Merged

feat(Global Catalog): add service and unit test code to project #6

merged 7 commits into from
Apr 24, 2020

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Apr 7, 2020 •
edited
Loading

PR summary

This PR adds the generated service and unit test code for the global-catalog service to the project.

Fixes: n/a

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Apr 7, 2020 •
edited
Loading

Codecov Report

Merging #6 into master will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   93.55%   93.80%   +0.25%     
==========================================
  Files           6        7       +1     
  Lines        1737     3728    +1991     
==========================================
+ Hits         1625     3497    +1872     
- Misses        112      231     +119
Impacted Files Coverage Δ
ibm_platform_services/global_catalog_v1.py 94.02% <ø> (ø)
ibm_platform_services/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2869dee...64aee89. Read the comment docs.

@padamstx padamstx self-assigned this Apr 10, 2020
@dubee dubee force-pushed the add-gc branch 18 times, most recently from 8533fc8 to 234d19b Compare April 24, 2020 04:44
@padamstx padamstx merged commit 04c9f84 into master Apr 24, 2020
ibm-devx-automation pushed a commit that referenced this pull request Apr 24, 2020
@semantic-release-bot
chore(release): 0.3.0 release notes
82f934f 
# [0.3.0](v0.2.0...v0.3.0) (2020-04-24)

### Features

* **Global Catalog:** add service and test code to project ([#6](#6)) ([04c9f84](04c9f84))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@padamstx padamstx deleted the add-gc branch May 4, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@padamstx @ibm-devx-automation @ibm-devx-sdk @dubee