Skip to content

Commit 4742b8e

Browse files
committed
fix(displlay_name): display_name unused in constructor
1 parent c4ba31d commit 4742b8e

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

ibm_cloud_sdk_core/base_service.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,11 @@ class BaseService(object):
3939
def __init__(self,
4040
service_url=None,
4141
authenticator=None,
42-
disable_ssl_verification=False,
43-
display_name=None):
42+
disable_ssl_verification=False):
4443
"""
45-
:attr str url: The url for service api calls
44+
:attr str service_url: The url for service api calls
4645
:attr Authenticator authenticator: The authenticator for authentication
4746
:attr bool disable_ssl_verification: enables/ disables ssl verification
48-
:attr str display_name the name used for mapping services in environment file
4947
"""
5048
self.service_url = service_url
5149
self.http_config = {}

test/test_base_service.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ def __init__(self,
2424
self,
2525
service_url=service_url,
2626
authenticator=authenticator,
27-
disable_ssl_verification=disable_ssl_verification,
28-
display_name='ibm Watson')
27+
disable_ssl_verification=disable_ssl_verification)
2928
self.version = version
3029

3130
def op_with_path_params(self, path0, path1):
@@ -419,7 +418,7 @@ def test_json():
419418
assert req.get('data') == "{\"hello\": \"world\"}"
420419

421420
def test_service_url_not_set():
422-
service = BaseService(service_url='', authenticator=NoAuthAuthenticator(), display_name='Watson')
421+
service = BaseService(service_url='', authenticator=NoAuthAuthenticator())
423422
with pytest.raises(ValueError) as err:
424423
service.prepare_request('POST', url='')
425424
assert str(err.value) == 'The service_url is required'

0 commit comments

Comments
 (0)