Skip to content

test: add tests that explicitly set the Host request header #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Jun 3, 2021

This PR just adds a few tests to verify that we can explicitly set the Host header in various ways such that it shows up in the resulting http request.

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #116 (dd92c09) into main (9787d2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          18       18           
  Lines         732      732           
=======================================
  Hits          723      723           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9787d2c...dd92c09. Read the comment docs.

@padamstx padamstx requested a review from rmkeezer June 3, 2021 23:12
Copy link
Contributor

@rmkeezer rmkeezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx padamstx merged commit 6614a63 into main Jun 4, 2021
@padamstx padamstx deleted the add-header-tests branch June 4, 2021 18:58
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 3.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants