fix: multiple IAM based authenticator overrides #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 22 22
Lines 815 815
=======================================
Hits 811 811
Misses 4 4
Continue to review full report at Codecov.
|
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Aug 24, 2021
## [3.11.3](v3.11.2...v3.11.3) (2021-08-24) ### Bug Fixes * multiple IAM based authenticator overrides ([#124](#124)) ([b142e9e](b142e9e))
|
🎉 This PR is included in version 3.11.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue which happens when the user creates more than one IAM based authenticator in the same service/project/file. The cause of this issue is the
request_payloadclass variable, because it should be an instance variable.Tests have been added, fixed and improved.
Closes #123
Update: there are also some unicode string and utf-8 encoding related changes in this PR to make the code compatible with the latest pylint release.