Skip to content

docs: sync Authentication.md with go core #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2021
Merged

docs: sync Authentication.md with go core #126

merged 2 commits into from
Oct 13, 2021

Conversation

padamstx
Copy link
Member

This PR syncs up the python core's Authentication.md file with the one from the go core.
Some wording changes, but mostly changes to the code examples to make sure they are equivalent to the go code examples (and also Java).

@padamstx padamstx requested a review from dpopp07 October 13, 2021 13:55
@padamstx padamstx self-assigned this Oct 13, 2021

## Cloud Pak for Data
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this section to after the Container Authenticator section.

Copy link

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #126 (2ae53f3) into main (9c8d90a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          22       22           
  Lines         815      815           
=======================================
  Hits          811      811           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9588f88...2ae53f3. Read the comment docs.

@padamstx padamstx merged commit fde6160 into main Oct 13, 2021
@padamstx padamstx deleted the update-auth-docs branch October 13, 2021 18:25
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 3.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants