Skip to content

test: minor updates to a few testcases #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024
Merged

test: minor updates to a few testcases #195

merged 1 commit into from
Jun 19, 2024

Conversation

padamstx
Copy link
Member

This commit makes some minor changes to a few testcases:

  1. test_api_exception.py: add tests for some requests.Response operations

  2. test_token_manager.py/test_jwt_token_manager.py: modified the abstract base class checks to work in Python 3.12 by matching only part of the error message that appears in the exception

  3. I also added python 3.12 to the travis build definition since I found and fixed a couple of unit test errors when using python 3.12

This commit makes some minor changes to a few testcases:
1. test_api_exception.py: add tests for some requests.Response
operations

2. test_token_manager.py/test_jwt_token_manager.py:
modified the abstract base class checks to work in Python 3.12
by matching only part of the error message that appears in the
exception

3. I also added python 3.12 to the travis build definition since
I found and fixed a couple of unit test errors when using python 3.12

Signed-off-by: Phil Adams <[email protected]>
@padamstx padamstx requested a review from dpopp07 June 19, 2024 18:48
@padamstx padamstx self-assigned this Jun 19, 2024
- python: 3.10
- python: 3.11
- python: 3.12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't seem right to build on FIVE versions of python so I removed python 3.9 so we would still be building on the current supported min version (3.8).

Copy link

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@padamstx padamstx merged commit 94f7321 into main Jun 19, 2024
4 checks passed
@padamstx padamstx deleted the update-tests branch June 19, 2024 21:11
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 3.20.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants