vcap and json loads changes

[ehdsouza]

This PR supports the following:

• Convert data object to string before making a request
• Temporary handle vcap services... This is a temporary change as we pass in only service name. So a VCAP service like compare-and-comply would be converted to compare_and_comply

[codecov]

Codecov Report

Merging #22 into next will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next      #22      +/-   ##
==========================================
+ Coverage   97.76%   97.99%   +0.22%     
==========================================
  Files          16       16              
  Lines         492      498       +6     
==========================================
+ Hits          481      488       +7     
+ Misses         11       10       -1

Impacted Files	Coverage Δ
ibm_cloud_sdk_core/base_service.py	96.74% <100%> (+0.08%)	⬆️
ibm_cloud_sdk_core/utils.py	98.01% <100%> (+1.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb7e88...8ef48a1. Read the comment docs.

[mediumTaj]

👍 looks good! Tagged @padamstx to review as well

[padamstx]

* Temporary handle vcap services... This is a temporary change as we pass in only `service name`. So a VCAP service like `compare-and-comply` would be converted to `compare_and_comply`

We shouldn't be doing any transformation on the service name when we use it to retrieve an entry in VCAP_SERVICES. If the service name obtained from the API definition and inserted into the generated code is "compare-and-comply", then that's the key that we'd expect to find in VCAP_SERVICES.
We only do the transformation on the service name when looking for properties in the credential file or environment variables.
There is a section on this in the Authentication design:
https://github.ibm.com/CloudEngineering/openapi-sdkgen/wiki/Core-SDK-Authentication-Design#a-note-about-service-names

[padamstx]

I left a comment after you already merged the PR.

[ehdsouza]

@padamstx this was done temporary before the meeting as a candidate release had to get out

[watson-github-bot]

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀