Model conversion #23
Merged
Model conversion #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #23 +/- ##
==========================================
+ Coverage 97.99% 98.18% +0.18%
==========================================
Files 16 16
Lines 498 495 -3
==========================================
- Hits 488 486 -2
+ Misses 10 9 -1
Continue to review full report at Codecov.
|
mkistler
suggested changes
Sep 1, 2019
| if isinstance(val, str): | ||
| val = json_import.loads(val) | ||
| val = classname._from_dict(dict(val)) | ||
| if hasattr(val, "_to_dict"): | ||
| return val._to_dict() | ||
| return val |
There was a problem hiding this comment.
I think this method could be even simpler, since there is no longer any need for the classname parameter:
def _convert_model(val):
if isinstance(val, str):
val = json_import.loads(val)
if hasattr(val, "_to_dict"):
return val._to_dict()
return val
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now since the
x-alternate-nameis not present in the api definitions of major release, we can remove the_from_dictstep to avoid potential errors received especially in import/ export workspace