Skip to content

logging, service_url and auth_type case insensitive changes #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2019

Conversation

ehdsouza
Copy link
Contributor

This PR contains the following:

  1. Show logging in readme
  2. Change url to service_url
  3. Validate that service_url is set in the prepare_request
  4. Make "auth type" case-insensitive

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #26 into next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #26      +/-   ##
==========================================
+ Coverage   98.18%   98.18%   +<.01%     
==========================================
  Files          16       16              
  Lines         495      497       +2     
==========================================
+ Hits          486      488       +2     
  Misses          9        9
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 97.54% <100%> (+0.04%) ⬆️
ibm_cloud_sdk_core/utils.py 98.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98046ed...459513e. Read the comment docs.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think you should add a test that uses mixed case authentication types just to be complete. I'll approve the PR now and you can add the tests separately.

@ehdsouza
Copy link
Contributor Author

@padamstx there is already a test case covering it: https://github.com/IBM/python-sdk-core/blob/next/resources/ibm-credentials-no-auth.env

@ehdsouza ehdsouza merged commit edd3bf3 into next Sep 12, 2019
@ehdsouza ehdsouza deleted the rc-changes-2 branch September 12, 2019 14:31
@watson-github-bot
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants