Skip to content

feat(disable-ssl-verification): log error for ssl error and others #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

ehdsouza
Copy link
Contributor

This PR adds error logs to various errors including ssl errors

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #29 into next will decrease coverage by 0.95%.
The diff coverage is 81.48%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next     #29      +/-   ##
=========================================
- Coverage   98.15%   97.2%   -0.96%     
=========================================
  Files          16      16              
  Lines         488     500      +12     
=========================================
+ Hits          479     486       +7     
- Misses          9      14       +5
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 93.7% <81.48%> (-3.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbaab0f...33a40d6. Read the comment docs.

Copy link
Member

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@ehdsouza ehdsouza merged commit 4fcaa66 into next Sep 23, 2019
@ehdsouza ehdsouza deleted the handle-ssl-error branch September 23, 2019 14:50
@watson-github-bot
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants