Skip to content

fix(configs): Pass cllient configs to token managers #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2019
Merged

fix(configs): Pass cllient configs to token managers #32

merged 1 commit into from
Oct 2, 2019

Conversation

ehdsouza
Copy link
Contributor

@ehdsouza ehdsouza commented Oct 2, 2019

fixes: #31

@ehdsouza ehdsouza requested a review from mediumTaj October 2, 2019 17:36
@codecov
Copy link

codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #32 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #32      +/-   ##
=========================================
+ Coverage   95.75%   95.8%   +0.04%     
=========================================
  Files           9       9              
  Lines         448     453       +5     
=========================================
+ Hits          429     434       +5     
  Misses         19      19
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 93.5% <100%> (+0.04%) ⬆️
ibm_cloud_sdk_core/jwt_token_manager.py 98.14% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5389d81...dc0c515. Read the comment docs.

@ehdsouza ehdsouza mentioned this pull request Oct 2, 2019
Merged
mediumTaj
mediumTaj approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@ehdsouza ehdsouza merged commit e1ff418 into master Oct 2, 2019
@ehdsouza ehdsouza deleted the proxy branch October 2, 2019 18:23
@watson-github-bot
Copy link

🎉 This PR is included in version 0.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mediumTaj mediumTaj mediumTaj approved these changes

Assignees
No one assigned
Labels
ready for review released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connecting to IBM Cloud through a proxy
3 participants
@ehdsouza @watson-github-bot @mediumTaj