fix: Fix date/datetime_to_string handling of non-date/datetime inputs #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 97.77% 97.78% +0.01%
==========================================
Files 17 17
Lines 584 588 +4
==========================================
+ Hits 571 575 +4
Misses 13 13
Continue to review full report at Codecov.
|
mkistler
force-pushed
the
fix-date-datetime-to-string
branch
from
f31c666 to
8251b82
Compare
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior of the recently added date/datetime_to_string methods to gracefully handle inputs that are not
dateordatetime. Most importantly, these methods should returnNoneif the input isNone. The new implementation simply returns the input argument whenever it is not of the expected type, which is consistent with the behavior of the other methods in the utils file.