-
Notifications
You must be signed in to change notification settings - Fork 29
Merge Python3 breaking changes from V2 to master #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 97.88% 97.89% +0.01%
==========================================
Files 17 17
Lines 616 619 +3
==========================================
+ Hits 603 606 +3
Misses 13 13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR is going to drop support for Python 2.7, you need to update the README. Also, I recommend stating Python 3.5.3 as the minimum Python version, as this is the version needed by aiohttp, and we'd like to have the option to use aiohttp for async requests without another major release of the Python core.
Before we can merge the v2 branch into master, we'll need to do these things:
For #2, this might be all of the commits, in which case we could do this:
|
BREAKING CHANGE: Keyword-specific optional parameters are new in Python3
* Only override content-type if it is none
BREAKING CHANGE: HTTPStatus is new in Python3
BREAKING CHANGE: Added super call feature new to Python3
BREAKING CHANGE: Type annotations new in Python3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and the commit messages appear to be fine.
Here's a suggestion for how to fully test this PR once it is merged into master:
- when this PR is merged into master, it will cause v2.0.0 of the python core to be created
- we have an open issue to add a system test stage to each template repository, so I'd like to suggest that you add the python system test stage to the python-sdk-template repo (.travis.yml), and update that template repo to require v2.0.0 of the python core (requirements.txt).
- when you submit your PR for feat(core): Add semantic release #2, the pr and push builds for that should run a python system test that incorporates the latest master-branch generator, along with your changes in the python-sdk-template repo which by extension will now use the new v2.0.0 of the core.
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
And ensure that the commit message is semantic release friendly for a breaking change 👍