feat(IAM Authenticator): add support for optional 'scope' property #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 97.97% 98.00% +0.02%
==========================================
Files 18 18
Lines 643 651 +8
==========================================
+ Hits 630 638 +8
Misses 13 13
Continue to review full report at Codecov.
|
jorge-ibm
force-pushed
the
feat/iam-scope
branch
2 times, most recently
from
dc204da to
8b0659f
Compare
jorge-ibm
force-pushed
the
feat/iam-scope
branch
from
8b0659f to
2e776c2
Compare
padamstx
approved these changes
Sep 18, 2020
| # Service2 configured with IAM w/scope | ||
| SERVICE_2_AUTH_TYPE=iam | ||
| SERVICE_2_APIKEY=V4HXmoUtMjohnsnow=KotN |
There was a problem hiding this comment.
No matter what @dpopp07 says, I'm ok with you spelling this "john" instead of "jon" :)
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IAM /identity/token (get token) operation supports an optional "scope" form parameter which can be used to obtain an IAM access token having a limited set of scopes in this it can be used.
This commit adds support for the "Scope" field within the IamTokenManager class. If set, the value of this field is sent as the "scope" form param in the "get token" request body when obtaining an access token.
ref: https://github.ibm.com/arf/planning-sdk-squad/issues/2167