feat(icp4d): refactor iam token manager and add icp4d support #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamoonraja
force-pushed
the
feat/icp4d-support
branch
from
1ad372a to
91e6e9a
Compare
mamoonraja
force-pushed
the
feat/icp4d-support
branch
from
91e6e9a to
c536b63
Compare
mediumTaj
suggested changes
Jun 21, 2019
mamoonraja
force-pushed
the
feat/icp4d-support
branch
from
9a0eb6d to
66da17e
Compare
mediumTaj
approved these changes
Jun 24, 2019
mamoonraja
force-pushed
the
feat/icp4d-support
branch
from
501a2ad to
f68f00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor how we handle IAM tokens and adds separate token managers to handle token operations.