Skip to content

Refactored boolean advanced indexing host tasks #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2023

Conversation

ndgrigorian
Copy link
Collaborator

Using multiple host_tasks when copying metadata to device has shown to cause crashes on CPU.
This PR addresses the issue by reducing the number of calls to device_allocate_and_pack.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

- Using a single host_task has shown to improve stability on CPU
@coveralls
Copy link
Collaborator

coveralls commented May 14, 2023

Coverage Status

Coverage: 83.322%. Remained the same when pulling 7a62edb on refactor-host-tasks into 1320d39 on master.

@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_50 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_51 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_52 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@ndgrigorian ndgrigorian merged commit b2a66d2 into master May 14, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_52 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@ndgrigorian ndgrigorian deleted the refactor-host-tasks branch July 27, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants