Skip to content

Correct libtensor preambles #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Correct libtensor preambles #1248

merged 1 commit into from
Jun 15, 2023

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jun 14, 2023

Changes preambles for common_inplace.hpp, kernels/boolean_advanced_indexing.hpp, source/integer_advanced_indexing.hpp, and integer_advanced_indexing.cpp to the correct filename and description.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

- common_inplace.hpp
- kernels/boolean_advanced_indexing.hpp
- source/integer_advanced_indexing.hpp
- source/integer_advanced_indexing.cpp
@ndgrigorian ndgrigorian force-pushed the common-inplace-header-fix branch from e511aa6 to 431b865 Compare June 14, 2023 22:58
@ndgrigorian ndgrigorian changed the title Fix common_inplace.hpp header Correct libtensor preambles Jun 14, 2023
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.117%. remained the same when pulling 431b865 on common-inplace-header-fix into 3794cbc on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_2 ran successfully.
Passed: 387
Failed: 613
Skipped: 119

@ndgrigorian ndgrigorian enabled auto-merge June 14, 2023 23:34
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_2 ran successfully.
Passed: 388
Failed: 612
Skipped: 119

@ndgrigorian ndgrigorian disabled auto-merge June 15, 2023 01:02
@ndgrigorian ndgrigorian merged commit cbd1f1e into master Jun 15, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_2 ran successfully.
Passed: 387
Failed: 613
Skipped: 119

@ndgrigorian ndgrigorian deleted the common-inplace-header-fix branch July 27, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants