Skip to content

update elementwise tests for exp, real, imag, and conj #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2023
Merged

update elementwise tests for exp, real, imag, and conj #1258

merged 2 commits into from
Jul 24, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jun 21, 2023 •
edited
Loading

In this PR, tests for dpctl.tensor.exp, dpctl.tensor.real, dpctl.tensor.imag, and dpctl.tensor.conj are updated. Implementation of dpt.exp is also modified to handle special cases for floating-point complex numbers correctly. Moreover, doc-strings are modified.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@vtavana vtavana self-assigned this Jun 21, 2023
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1258/index.html

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_11 ran successfully.
Passed: 413
Failed: 587
Skipped: 119

@vtavana vtavana force-pushed the update_elementwise_tests branch from 8ef97a0 to 47d9266 Compare June 23, 2023 02:28
@vtavana vtavana changed the base branch from elementwise-floor-ceil-trunc to master June 23, 2023 02:29
@vtavana vtavana changed the base branch from master to elementwise-floor-ceil-trunc June 23, 2023 02:29
@vtavana vtavana changed the base branch from elementwise-floor-ceil-trunc to master June 23, 2023 02:29
@vtavana vtavana marked this pull request as ready for review June 23, 2023 02:31
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_11 ran successfully.
Passed: 415
Failed: 585
Skipped: 119

oleksandr-pavlyk
oleksandr-pavlyk reviewed Jun 26, 2023
View reviewed changes
@ndgrigorian ndgrigorian force-pushed the update_elementwise_tests branch from 47d9266 to e9829fc Compare June 26, 2023 17:35
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_12 ran successfully.
Passed: 388
Failed: 612
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Jun 26, 2023 •
edited
Loading

Coverage Status

coverage: 83.218%. remained the same when pulling ac20262 on update_elementwise_tests into 73a2b68 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.4=py310h7bf5fec_13 ran successfully.
Passed: 387
Failed: 613
Skipped: 119

@ndgrigorian ndgrigorian requested a review from npolina4 June 27, 2023 21:38
@vtavana vtavana force-pushed the update_elementwise_tests branch from 5c97b05 to cc26d78 Compare July 17, 2023 13:50
oleksandr-pavlyk
oleksandr-pavlyk reviewed Jul 17, 2023
View reviewed changes
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5dev1=py310h7bf5fec_11 ran successfully.
Passed: 448
Failed: 552
Skipped: 119

@vtavana vtavana force-pushed the update_elementwise_tests branch 2 times, most recently from 0c53d67 to 69382f1 Compare July 18, 2023 18:14
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5=py310h7bf5fec_2 ran successfully.
Passed: 448
Failed: 552
Skipped: 119

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5=py310h7bf5fec_2 ran successfully.
Passed: 448
Failed: 552
Skipped: 119

@vtavana vtavana force-pushed the update_elementwise_tests branch 2 times, most recently from b406e4f to 47dcb05 Compare July 21, 2023 22:15
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_24 ran successfully.
Passed: 475
Failed: 525
Skipped: 119

@vtavana vtavana force-pushed the update_elementwise_tests branch from 47dcb05 to ba52635 Compare July 22, 2023 00:12
@vtavana vtavana force-pushed the update_elementwise_tests branch from ba52635 to e6af2bc Compare July 22, 2023 00:14
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_24 ran successfully.
Passed: 475
Failed: 525
Skipped: 119

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_24 ran successfully.
Passed: 475
Failed: 525
Skipped: 119

@vtavana vtavana changed the title update elementwise tests update elementwise tests for exp, real, imag, and conj Jul 22, 2023
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_25 ran successfully.
Passed: 474
Failed: 526
Skipped: 119

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @vtavana

@vtavana vtavana merged commit 7c0a54f into master Jul 24, 2023
@vtavana vtavana deleted the update_elementwise_tests branch July 24, 2023 20:57
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_25 ran successfully.
Passed: 475
Failed: 525
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @oleksandr-pavlyk