Skip to content

Revert "Update w/a to Klocwork (#1252)" #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2023
Merged

Revert "Update w/a to Klocwork (#1252)" #1289

merged 3 commits into from
Jul 21, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

This reverts commit f15ec81.

This workaround, if needed, should only have been applied conditionally.
Anyhow, we transition to use Coverity now, so this workaround is no longer necessary.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1289/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jul 18, 2023 •
edited
Loading

Coverage Status

coverage: 83.218%. remained the same when pulling c2bb595 on revert-kw-workaround into 20c5d3c on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5=py310h7bf5fec_2 ran successfully.
Passed: 448
Failed: 552
Skipped: 119

antonwolfy
antonwolfy reviewed Jul 19, 2023
View reviewed changes
conda-recipe/build.sh Outdated
@@ -4,7 +4,6 @@
# by DPC++ compiler conda packages. Will need to be added to DPC++ compiler
# activation scripts.
export LDFLAGS="$LDFLAGS -Wl,-rpath,$PREFIX/lib"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that also relating to the W/A and should be removed? At least the above comment claims regarding that.

@oleksandr-pavlyk
Copy link
Contributor Author

Thank you for catching this @antonwolfy . I have removed setting of the LDFLAGS and the comment.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_19 ran successfully.
Passed: 474
Failed: 526
Skipped: 119

vlad-perevezentsev
vlad-perevezentsev approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit 8d100d1 into master Jul 21, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the revert-kw-workaround branch July 21, 2023 16:46
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_19 ran successfully.
Passed: 474
Failed: 526
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@xaleryb xaleryb Awaiting requested review from xaleryb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oleksandr-pavlyk @coveralls @vlad-perevezentsev @antonwolfy