Skip to content

test_async_submit is to try few times before failing #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

test_sycl_kernel_submit::test_async_submit sporadically fails on Windows where in kernels finish execution before test checks are done. Typical remedy is to restart Windows tests and after few iterations they pass.

This PR changes the tests to attempt launching kernels few times and rechecking tests condition before asserting test failure.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 83.195%. remained the same when pulling 0bdc6a1 on tweak-test-submit-async-take-2 into f52182d on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5=py310h7bf5fec_2 ran successfully.
Passed: 448
Failed: 552
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit 43e3870 into master Jul 19, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the tweak-test-submit-async-take-2 branch July 19, 2023 03:00
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_7 ran successfully.
Passed: 474
Failed: 526
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants