Fixed failure of test_floor_ceil_trunc_errors, sped up usm_type test #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since support for overlapping out and argument arrays has been added the expected TypeError is no longer raised. Do not use `np.float32(usm_ndarray)` use-pattern, use `dpt.asnumpy(usm_ndarray)` instead. The former generates usm_ndarray.size single-element device-to-host transfers, while the latter does it in a single kernel invocation.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1292/index.html |
|
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_9 ran successfully. |
vtavana
approved these changes
Jul 19, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_9 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since support for overlapping out and argument arrays has been added the expected TypeError is no longer raised.
Do not use
np.float32(usm_ndarray)use-pattern, usedpt.asnumpy(usm_ndarray)instead. The former generates usm_ndarray.size single-element device-to-host transfers, while the latter does it in a single kernel invocation.