Update for cython 3 #1302
Merged
Update for cython 3 #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes per https://cython.readthedocs.io/en/latest/src/userguide/external_C_code.html Capsule deleter functions are marked noexcept except/noexcept must be specified before gil/no gil. cpdef functions should not have except qualifiers.
Added ``` ``` to quieten mightly flood of warnings.
This reverts commit 03a46e1.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1302/index.html |
|
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_31 ran successfully. |
antonwolfy
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Checked with dpnp build, it works fine, no dpctl relating warning. Thank you @oleksandr-pavlyk !
|
I should also add that after this PR the source remains buildable with Cython 0.29.36 |
ndgrigorian
approved these changes
Jul 31, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_65 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes gh-1277, reverts 03a46e1 to enable Cython 3.0, modifies Cython files per Cython guidance, and removes deprecated in 2023.2
sycl::aspect::usm_restricted_shared_allocationsanddpctl.SyclDevice.has_aspect_usm_restricted_shared_allocationsproperty.