Skip to content

Removes redundant output types from logical and comparison functions #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2023
Merged

Removes redundant output types from logical and comparison functions #1309

merged 1 commit into from
Jul 29, 2023
+108 −554

Conversation

ndgrigorian
Copy link
Collaborator

This pull request simplifies the comparison functions by removing unnecessary output type specializations for float and std::complex<float>.

This reduces the amount of code generation, in hopes of decreasing the binary size.

This PR also fixes typos throughout the elementwise functions and implements the templates from elementwise_common where they were not being used.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Removed unnecessary output types from logical and comparison elementw…
34a78db 
…ise functions

Logical and comparison functions were constructing kernels for mixed 32-bit floats and 64-bit complex numbers.
To prevent binary size inflation, these have been removed.

Logical and comparison operations now also elementwise_common templates

Corrected various typos
@ndgrigorian ndgrigorian marked this pull request as draft July 28, 2023 15:40
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1309/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 83.265%. remained the same when pulling 34a78db on elementwise-function-housekeeping into 47f4bc9 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_51 ran successfully.
Passed: 567
Failed: 433
Skipped: 119

@oleksandr-pavlyk
Copy link
Contributor

@ndgrigorian Do you intend to check in additional changes in this PR? I think it is ready to graduate to ready for review if not.

@ndgrigorian ndgrigorian marked this pull request as ready for review July 28, 2023 19:23
@ndgrigorian
Copy link
Collaborator Author

@ndgrigorian Do you intend to check in additional changes in this PR? I think it is ready to graduate to ready for review if not.

I don't, I've converted the PR to ready for review.

@oleksandr-pavlyk
Copy link
Contributor

@ndgrigorian Thank you for the clean up! LGTM

@oleksandr-pavlyk oleksandr-pavlyk merged commit 45ed4d5 into master Jul 29, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the elementwise-function-housekeeping branch July 29, 2023 20:25
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_56 ran successfully.
Passed: 594
Failed: 406
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk