Skip to content

flake8 6.1.0 fixes #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2023
Merged

flake8 6.1.0 fixes #1312

merged 1 commit into from
Jul 30, 2023

Conversation

ndgrigorian
Copy link
Collaborator

This PR aims to fix dpctl's flake8 style conformity and the flake8 CI, which have both been changed by flake8 releasing version 6.1.0.

Checks for equality between types (i.e., type(x) == type(y)) have been changed to use the is keyword to that end.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian marked this pull request as ready for review July 30, 2023 05:21
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.776%. remained the same when pulling 99c4a4a on fix-for-flake8-610 into 45ed4d5 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_58 ran successfully.
Passed: 595
Failed: 405
Skipped: 119

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @ndgrigorian

@ndgrigorian ndgrigorian merged commit 1cc45e4 into master Jul 30, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@ndgrigorian ndgrigorian deleted the fix-for-flake8-610 branch July 30, 2023 15:35
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_57 ran successfully.
Passed: 594
Failed: 406
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants