Skip to content

Clean-up: removed unused symbol in full_ctor.cpp #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Remove using statement adding an unused qualifier to the namespace.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.776%. remained the same when pulling 2f9ea6f on clean-up-full-ctor-cpp into 1cc45e4 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_59 ran successfully.
Passed: 593
Failed: 407
Skipped: 119

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

@oleksandr-pavlyk oleksandr-pavlyk merged commit dcca136 into master Jul 31, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the clean-up-full-ctor-cpp branch July 31, 2023 23:14
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_67 ran successfully.
Passed: 594
Failed: 406
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants