Skip to content

Fix missing string format in isdtype #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix missing string format in isdtype #1315

merged 1 commit into from
Jul 31, 2023

Conversation

fcharras
Copy link
Contributor

Fix a small mistake in dpt.isdtype that prevent wrong user input to be correctly displayed in the error message:

TypeError: Expected instance of dpt.dtype, got {dtype_}

@intel-python-devops
Copy link

Can one of the admins verify this patch?

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fcharras, appreciate your contribution!

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.776%. remained the same when pulling 1e6c520 on fcharras:patch-1 into 02448c4 on IntelPython:master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit f0bbafc into IntelPython:master Jul 31, 2023
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_60 ran successfully.
Passed: 594
Failed: 406
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fcharras @intel-python-devops @coveralls @oleksandr-pavlyk